Skip to content

chore: Update Druid product version to 31.0.1 and adjust coordinator memory limit #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 27, 2025

Conversation

dervoeti
Copy link
Member

@dervoeti dervoeti commented Jan 29, 2025

Description

Part of stackabletech/docker-images#965

I had to increase the memory limit of the coordinator and middlemanager, otherwise the authorization integration test fails because the Pods get OOMKilled (happens on my local machine and on Replicated).

I also had to adapt the authorization integration test to support druid-opa-authorizer 0.6.0 (introduced by stackabletech/docker-images#984).

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@NickLarsenNZ NickLarsenNZ changed the title chore: Update Druid product version to 31.0.1 and adjust coordinator memory limit chore: Update Druid product version to 31.0.1, update OPA to 1.0.0, and adjust coordinator memory limit Jan 29, 2025
@NickLarsenNZ NickLarsenNZ changed the title chore: Update Druid product version to 31.0.1, update OPA to 1.0.0, and adjust coordinator memory limit chore: Update Druid product version to 31.0.1, update OPA to 1.0.0, and adjust coordinator memory limit Jan 29, 2025
@dervoeti dervoeti force-pushed the chore/update-druid-to-31.0.1 branch 2 times, most recently from 735c50a to 15698d8 Compare January 29, 2025 20:59
@NickLarsenNZ

This comment was marked as outdated.

@dervoeti
Copy link
Member Author

dervoeti commented Feb 5, 2025

Just noting that this is blocking stackabletech/docker-images#969

Oh, right. And since this PR, or rather all Druid 31.0.1 PRs, are blocked by this decision and it might take a while, I removed the OPA bump from this PR (was not really necessary anyway, but I thought this PR would be a quick one). I'll open a separate PR for the OPA bump.

@dervoeti dervoeti changed the title chore: Update Druid product version to 31.0.1, update OPA to 1.0.0, and adjust coordinator memory limit chore: Update Druid product version to 31.0.1 and adjust coordinator memory limit Feb 5, 2025
@dervoeti dervoeti force-pushed the chore/update-druid-to-31.0.1 branch 2 times, most recently from 285aa14 to 2daed10 Compare February 10, 2025 08:04
@dervoeti dervoeti force-pushed the chore/update-druid-to-31.0.1 branch from 7c70e1f to 911d483 Compare February 26, 2025 16:45
@dervoeti dervoeti requested a review from a team February 27, 2025 13:31
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please also update https://docs.stackable.tech/home/stable/druid/usage-guide/resources-and-storage/

Fun fact: @NickLarsenNZ also just chatted me about increasing the memory default ;)

@dervoeti dervoeti force-pushed the chore/update-druid-to-31.0.1 branch from 6f0d84b to cb4d110 Compare February 27, 2025 14:37
@dervoeti
Copy link
Member Author

Thanks! Please also update https://docs.stackable.tech/home/stable/druid/usage-guide/resources-and-storage/

Fun fact: @NickLarsenNZ also just chatted me about increasing the memory default ;)

Done 🙂

sbernauer
sbernauer previously approved these changes Feb 27, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Let's get this in before #693

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@dervoeti dervoeti enabled auto-merge February 27, 2025 14:59
@dervoeti dervoeti added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit 3878bff Feb 27, 2025
17 checks passed
@dervoeti dervoeti deleted the chore/update-druid-to-31.0.1 branch February 27, 2025 15:11
@dervoeti dervoeti moved this from Development: In Review to Development: Done in Stackable Engineering Mar 3, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants