Skip to content

feat: Add region field to S3Connection and S3Bucket CRDs #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Feb 20, 2025

Description

Part of stackabletech/docker-images#971.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] CRD changes approved: https://github.com/stackabletech/decisions/issues/46
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@NickLarsenNZ NickLarsenNZ self-assigned this Feb 20, 2025
@NickLarsenNZ NickLarsenNZ changed the title wip: bump stackable-operator feat: Add region field to S3Connection CRD Feb 20, 2025
@NickLarsenNZ NickLarsenNZ marked this pull request as ready for review February 21, 2025 10:56
@NickLarsenNZ NickLarsenNZ force-pushed the feat/s3-connection-region branch from 03d7e47 to b579210 Compare February 21, 2025 11:00
@NickLarsenNZ NickLarsenNZ changed the title feat: Add region field to S3Connection CRD feat: Add region field to S3Connection and S3Bucket CRDs Feb 21, 2025
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 4994a49 Feb 21, 2025
17 checks passed
@NickLarsenNZ NickLarsenNZ deleted the feat/s3-connection-region branch February 21, 2025 11:15
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants