Skip to content

Commit 4994a49

Browse files
authored
feat: Add region field to S3Connection and S3Bucket CRDs (#331)
* feat: Add region field to S3Connection * chore: Update changelog
1 parent b50f462 commit 4994a49

File tree

6 files changed

+71
-17
lines changed

6 files changed

+71
-17
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ All notable changes to this project will be documented in this file.
1111
### Added
1212

1313
- Aggregate emitted Kubernetes events on the CustomResources ([#318]).
14+
- Add the region field to the S3Connection CRD ([#331]).
1415

1516
### Changed
1617

@@ -19,6 +20,7 @@ All notable changes to this project will be documented in this file.
1920
[#318]: https://github.com/stackabletech/commons-operator/pull/318
2021
[#320]: https://github.com/stackabletech/commons-operator/pull/320
2122
[#321]: https://github.com/stackabletech/commons-operator/pull/321
23+
[#331]: https://github.com/stackabletech/commons-operator/pull/331
2224

2325
## [24.11.1] - 2025-01-09
2426

Cargo.lock

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.nix

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ futures = { version = "0.3", features = ["compat"] }
1717
serde = { version = "1.0", features = ["derive"] }
1818
serde_json = "1.0"
1919
snafu = "0.8"
20-
stackable-operator = { git = "https://github.com/stackabletech/operator-rs.git", tag = "stackable-operator-0.85.0" }
20+
stackable-operator = { git = "https://github.com/stackabletech/operator-rs.git", tag = "stackable-operator-0.86.1" }
2121
strum = { version = "0.26", features = ["derive"] }
2222
tokio = { version = "1.40", features = ["full"] }
2323
tracing = "0.1"

crate-hashes.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

deploy/helm/commons-operator/crds/crds.yaml

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,32 @@ spec:
366366
minimum: 0.0
367367
nullable: true
368368
type: integer
369+
region:
370+
default:
371+
name: us-east-1
372+
description: |-
373+
AWS service API region used by the AWS SDK when using AWS S3 buckets.
374+
375+
This defaults to `us-east-1` and can be ignored if not using AWS S3 buckets.
376+
377+
NOTE: This is not the bucket region, and is used by the AWS SDK to construct endpoints for various AWS service APIs. It is only useful when using AWS S3 buckets.
378+
379+
When using AWS S3 buckets, you can configure optimal AWS service API connections in the following ways: - From **inside** AWS: Use an auto-discovery source (eg: AWS IMDS). - From **outside** AWS, or when IMDS is disabled, explicity set the region name nearest to where the client application is running from.
380+
oneOf:
381+
- required:
382+
- source
383+
- required:
384+
- name
385+
properties:
386+
name:
387+
description: 'An explicit region, eg: eu-central-1'
388+
type: string
389+
source:
390+
description: Defer region detection to an auto-discovery mechanism.
391+
enum:
392+
- AwsImds
393+
type: string
394+
type: object
369395
tls:
370396
description: Use a TLS connection. If not specified no TLS will be used.
371397
nullable: true
@@ -507,6 +533,32 @@ spec:
507533
minimum: 0.0
508534
nullable: true
509535
type: integer
536+
region:
537+
default:
538+
name: us-east-1
539+
description: |-
540+
AWS service API region used by the AWS SDK when using AWS S3 buckets.
541+
542+
This defaults to `us-east-1` and can be ignored if not using AWS S3 buckets.
543+
544+
NOTE: This is not the bucket region, and is used by the AWS SDK to construct endpoints for various AWS service APIs. It is only useful when using AWS S3 buckets.
545+
546+
When using AWS S3 buckets, you can configure optimal AWS service API connections in the following ways: - From **inside** AWS: Use an auto-discovery source (eg: AWS IMDS). - From **outside** AWS, or when IMDS is disabled, explicity set the region name nearest to where the client application is running from.
547+
oneOf:
548+
- required:
549+
- source
550+
- required:
551+
- name
552+
properties:
553+
name:
554+
description: 'An explicit region, eg: eu-central-1'
555+
type: string
556+
source:
557+
description: Defer region detection to an auto-discovery mechanism.
558+
enum:
559+
- AwsImds
560+
type: string
561+
type: object
510562
tls:
511563
description: Use a TLS connection. If not specified no TLS will be used.
512564
nullable: true

0 commit comments

Comments
 (0)