-
Notifications
You must be signed in to change notification settings - Fork 172
Upgrade TS, Canvas to v3 #3115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade TS, Canvas to v3 #3115
Conversation
FAIL src/commons/sagas/__tests__/PlaygroundSaga.ts
● Test suite failed to run
Cannot find module 'canvas' from 'node_modules/konva/lib/index-node.js'
Require stack:
node_modules/konva/lib/index-node.js
node_modules/react-konva/lib/ReactKonva.js
src/features/cseMachine/CseMachineLayout.tsx
src/features/cseMachine/CseMachine.tsx
src/commons/utils/JsSlangHelper.ts
src/commons/application/ApplicationTypes.ts
src/commons/sagas/__tests__/PlaygroundSaga.ts
4 | import { KonvaEventObject } from 'konva/lib/Node';
5 | import React, { RefObject } from 'react';
> 6 | import { Layer, Rect, Stage } from 'react-konva';
| ^
7 | import classes from 'src/styles/Draggable.module.scss'; From konva README page:
|
Right, in that case I will upgrade canvas instead as v2 doesn't work with NodeJS 22 on Windows |
Pull Request Test Coverage Report for Build 14175319556Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the current recommended version of node should still be 20, but having it compatible with the newer version is good as well.
Agreed, we should aim to futureproof when possible |
Description
Fixes build errors with NodeJS 22 on Windows
Checklist