Skip to content

Commit 651ace7

Browse files
authored
Upgrade TS, drop Canvas dependency (#3115)
* Bump TS and remove canvas * Fix errors post-updates * Fix format * Upgrade canvas to v3
1 parent 0bd3a5e commit 651ace7

File tree

4 files changed

+164
-253
lines changed

4 files changed

+164
-253
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@
135135
"@types/xml2js": "^0.4.11",
136136
"babel-jest": "^29.7.0",
137137
"buffer": "^6.0.3",
138-
"canvas": "^2.11.2",
138+
"canvas": "^3.1.0",
139139
"constants-browserify": "^1.0.0",
140140
"coveralls": "^3.1.1",
141141
"cross-env": "^7.0.3",
@@ -162,7 +162,7 @@
162162
"stream-browserify": "^3.0.0",
163163
"stream-http": "^3.2.0",
164164
"timers-browserify": "^2.0.12",
165-
"typescript": "^5.5.3",
165+
"typescript": "^5.8.2",
166166
"typescript-eslint": "^8.1.0",
167167
"url": "^0.11.1",
168168
"webpack-bundle-analyzer": "^4.9.0"

src/features/game/dialogue/GameDialogueGenerator.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export default class DialogueGenerator {
1414
*/
1515
public constructor(dialogueContent: DialogueObject) {
1616
this.dialogueContent = dialogueContent;
17-
this.currPart = dialogueContent.keys().next().value;
17+
this.currPart = dialogueContent.keys().next().value || '';
1818
this.currLineNum = 0;
1919
}
2020

src/styles/_achievementdashboard.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -629,7 +629,7 @@
629629
color: white;
630630
display: flex;
631631
flex-direction: column;
632-
height: $view-height / 3;
632+
height: calc($view-height / 3);
633633
justify-content: center;
634634
margin: 1em auto;
635635
width: $view-width;

0 commit comments

Comments
 (0)