-
Notifications
You must be signed in to change notification settings - Fork 315
remove vague addition store setter filter #1161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove vague addition store setter filter #1161
Conversation
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Please read the contributing guidelines prior to sending in a PR! |
added context to the inspiration/reason of this PR if you think that instead of removing the line you prefer to add a code example that is also acceptable |
@LadyBluenotes can we have another look at this for @mizulu? |
thanks @davedbase, also if you don't mind can you look into my discord standings |
@mizulu I've lifted the ban. Please remember to be kind and considerate to other members. |
Co-authored-by: Sarah <hello@sarahgerrard.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for helping out with this!
Thank you for taking the time to open this PR! We appreciate your contribution and effort in helping improve the project.
Description(required)
this line is a source of confusion, and if to remain lacks an example
to see its value.
Related issues & labels
documentation