Skip to content

remove vague addition store setter filter #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mizulu
Copy link
Contributor

@mizulu mizulu commented Apr 24, 2025

Thank you for taking the time to open this PR! We appreciate your contribution and effort in helping improve the project.

  • [ yes ] I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

image

this line is a source of confusion, and if to remain lacks an example
to see its value.

Related issues & labels

  • Closes #
  • Suggested label(s) (optional):
    documentation

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Apr 24, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 36c61c4
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/6812ec1250b08500085d88e7
😎 Deploy Preview https://deploy-preview-1161--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LadyBluenotes
Copy link
Member

Please read the contributing guidelines prior to sending in a PR!

@solidjs solidjs locked and limited conversation to collaborators Apr 24, 2025
@solidjs solidjs unlocked this conversation Apr 24, 2025
@mizulu
Copy link
Contributor Author

mizulu commented Apr 24, 2025

added context to the inspiration/reason of this PR

if you think that instead of removing the line you prefer to add a code example that is also acceptable
just explain the original intention of this comment and see if it makes sense or it is an oversight

@davedbase davedbase reopened this Apr 27, 2025
@davedbase
Copy link
Member

@LadyBluenotes can we have another look at this for @mizulu?

@mizulu
Copy link
Contributor Author

mizulu commented Apr 27, 2025

@LadyBluenotes can we have another look at this for @mizulu?

thanks @davedbase, also if you don't mind can you look into my discord standings

@davedbase
Copy link
Member

@mizulu I've lifted the ban. Please remember to be kind and considerate to other members.

Co-authored-by: Sarah <hello@sarahgerrard.me>
Copy link
Member

@LadyBluenotes LadyBluenotes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping out with this!

@LadyBluenotes LadyBluenotes merged commit c4bc59d into solidjs:main May 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants