Skip to content

pkg/types/core: add SettingsBroadcaster #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pkg/types/core: add SettingsBroadcaster #1684

wants to merge 1 commit into from
+530 −64

Conversation

@jmank88
Copy link
Contributor

@jmank88 jmank88 commented Nov 4, 2025 •
edited
Loading

https://smartcontract-it.atlassian.net/browse/CRE-545

Add SettingsBroadcaster for broadcasting CRE settings from host to capabilities plugins.

Supports:

@github-actions
Copy link

github-actions bot commented Nov 4, 2025 •
edited
Loading

⚠️ API Diff Results - Breaking changes detected

📦 Module: github-com-smartcontractkit-chainlink-common

🔴 Breaking Changes (2)

pkg/loop (2)
  • MustNewStartedServer — Type changed:
func(
  - string
  + string, 
  + ...ServerOpt
)
*Server
  • NewStartedServer — Type changed:
func(
  - string
  + string, 
  + ...ServerOpt
)
(*Server, error)

📄 View full apidiff report

@jmank88 jmank88 mentioned this pull request Nov 4, 2025
Draft
@jmank88 jmank88 force-pushed the CRE-545-settings-realtime branch from 0712c6d to e64f47c Compare November 4, 2025 16:58
@jmank88 jmank88 marked this pull request as ready for review November 4, 2025 16:58
@jmank88 jmank88 requested a review from a team as a code owner November 4, 2025 16:58
@jmank88 jmank88 force-pushed the CRE-545-settings-realtime branch from e64f47c to a9adb47 Compare November 4, 2025 17:17
@jmank88 jmank88 enabled auto-merge (squash) November 4, 2025 18:01
@jmank88 jmank88 requested a review from ilija42 November 4, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mchain0 mchain0 mchain0 approved these changes

@krehermann krehermann Awaiting requested review from krehermann

@pavel-raykov pavel-raykov Awaiting requested review from pavel-raykov

@EasterTheBunny EasterTheBunny Awaiting requested review from EasterTheBunny

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

@bolekk bolekk Awaiting requested review from bolekk

@ilija42 ilija42 Awaiting requested review from ilija42

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmank88 @mchain0