fix: allow overwriting delta lake entries with same timestamp #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without allowing this, we can't meaningfully update rows as ETL evolves to allow more content (_data and _url fields recently, maybe future allowed extensions, that sort of thing). This does allow more data churn, but correctness takes priority.
mikix
force-pushed
the
mikix/timestamp-equal
branch
from
1f45159 to
4edad9c
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
dogversioning
approved these changes
Nov 19, 2024
Comment on lines
+212
to
+213
| # If we eventually decide that sub-second updates are a real concern, we can additionally | ||
| # compare versionId. But I don't know how you extracted both versions so quickly. :) |
There was a problem hiding this comment.
yeah i don't think we're going to have this problem any time soon
There was a problem hiding this comment.
But correctness Maaaatt!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without allowing this, we can't meaningfully update rows as ETL evolves to allow more content (_data and _url fields recently, maybe future allowed extensions, that sort of thing).
This does allow more data churn, but correctness takes priority. We could maybe get both if we inserted the ETL version into every row? But for now, this is an easy tweak.
Checklist
docs/) needs to be updated