Skip to content

Removed unnecessary setup code #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

hsbt
Copy link
Contributor

@hsbt hsbt commented Dec 12, 2024

tmp/test-pipes is no longer needed from b4ad8f4. I removed that.

@hsbt
Copy link
Contributor Author

hsbt commented Dec 12, 2024

I found this on the integration of ruby/ruby repository at ruby/ruby#12250

Copy link
Collaborator

@ilyazub ilyazub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks!

Comment on lines -113 to -121
def setup_tmp_dir
begin
FileUtils.rm_r("tmp/test-pipes")
rescue Errno::ENOENT
end

FileUtils.mkdir_p("tmp/test-pipes/")
end

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ilyazub ilyazub merged commit da3fc60 into serpapi:master Mar 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants