Skip to content

Tracking Meta PR of all PRs #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Conversation

pboling
Copy link

@pboling pboling commented Jan 14, 2025

Update: I was in the process of upgrading, improving, rebasing, & merging all PRs on this repo against my tracking repo.
However, in light of the following:

I've decided to stop working on this branch. I'll leave it up for others. If the three above issues are not deal breakers for you, this branch does work quite well, and I think it would be a good starting place for @ilyazub to further modernize this gem.

pboling and others added 30 commits January 11, 2025 09:23
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…actions/upload-artifact-4

Bump actions/upload-artifact from 3 to 4
Support parallel_tests options
Support reading `.rspec_parallel`
@pboling
Copy link
Author

pboling commented Mar 1, 2025

@ilyazub If you'd be interested in adding a maintainer, I'll apply for the role!

@ilyazub
Copy link
Collaborator

ilyazub commented Mar 4, 2025

@pboling Thanks for all the help! I'll review the PRs and get back you about the maintainer role.

@pboling
Copy link
Author

pboling commented Mar 4, 2025

You can see the results of the CI on the fork here: https://github.com/VitalConnectInc/turbo_tests/actions

I expect it to pass here as well, once the workflow is approved.

@pboling pboling mentioned this pull request Mar 7, 2025
@pboling
Copy link
Author

pboling commented Mar 7, 2025

@ilyazub Update: In light of the following:

I've decided to stop working on this branch. I'll leave it up for others. If the three above issues are not deal breakers for you, this branch does work quite well, and I think it would be a good starting place for further work on this gem.

@pboling
Copy link
Author

pboling commented Mar 7, 2025

@ilyazub I think you're going to make a lot more work for yourself if you merge the other PRs individually. It was a lot of work to rebase everything to get it all working together here, and add lots of specs, and get CI passing... and now this PR is in conflict.

In case it wasn't clear, I carefully retained the "authorship" of the original commiters, so merging this does make them all contributors.

@pboling
Copy link
Author

pboling commented Mar 7, 2025

@ilyazub FWIW, the PRs I made against my repo where I rebased the original PRs against your repo, are all linked as the nested bullets in the OP description. If you want to use those to individually merge things, it would be easiest if you did them in order, since otherwise the rebasing will get out of sync.

@chaadow
Copy link

chaadow commented Apr 27, 2025

@pboling Thanks for this meta PR, this comes in clutch for me

@pboling
Copy link
Author

pboling commented Apr 28, 2025

@chaadow so glad! FYI, I am no longer involved with that fork, and it might disappear at any time, so if you want it in a reliable state, you should (re)fork it!

@chaadow
Copy link

chaadow commented May 3, 2025

@pboling Oh thanks for letting me know! I'm curious, do you use another gem or another fork perhaps?

@pboling
Copy link
Author

pboling commented May 3, 2025

I switched back to vanilla parallel_tests (which recently released a v5). The incompatibility with SimpleCov was insurmountable for me, and I didn't have time to fix it. It's not a minor refactor.

btw, I use a gem I made to make configuring SimpleCov easy on every project: kettle-soup-cover - I'm really into code coverage. 🥇

@phyzical
Copy link

@pboling quick question, off topic but with parallel v5 is it possible to combine the failures into a single output at the end?

i believe that was our biggest reason to switch over to turbo

@pboling
Copy link
Author

pboling commented Jun 18, 2025

I think if you configure the command_name to be unique for each parallel process your results will be auto-merged by SimpleCov.

SimpleCov.start 'rails' do
  command_name "RSpec #{Process.pid}" # or a unique identifier
end

@phyzical
Copy link

sorry i think the simplecov did its job from memory

it was around the list of failed test overviews, as you would end up having to scroll through each set when a failure/s occurred.

But on review of parallel, it looks like we might just have to configure it to save to file and just re dump at the end of the test run ourselves if we switch back (was just wondering if something had changed since, but looks like it hasnt)

@pboling
Copy link
Author

pboling commented Jun 20, 2025

Yeah, that was the main benefit of turbo_tests. I agree with your analysis 🧐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants