Skip to content

Use PARALLEL_TESTS_EXECUTABLE environmental variable if it's provided #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

hsbt
Copy link
Contributor

@hsbt hsbt commented Dec 4, 2024

👋 Thank you for maintaining turbo_tests.

I would like to use turbo_tests on ruby/ruby same as rubygems/rubygems for testing bundler. see ruby/ruby#12250.

We used parallel_tests because turbo_tests didn't support ENV["PARALLEL_TESTS_EXECUTABLE"] for custom executable on parallel_tests. I added new condition for that around command_name.

How about this? Thank you for reading this.

@deivid-rodriguez
Copy link
Contributor

Should this be RSPEC_EXECUTABLE or something like that?

My understanding is that PARALLEL_TESTS_EXECUTABLE is a parallel_tests thing that helps in environments where ruby needs to be run differently (like in ruby-core test setup), but the way it's implemented here it's replacing rspec, so the consumer of this library will need to include some command line to help running rspec in the ENV, right?

@hsbt
Copy link
Contributor Author

hsbt commented Dec 9, 2024

Should this be RSPEC_EXECUTABLE or something like that?

I have no strong opinion about that. RSPEC_EXECUTABLE is okay to me.

My understanding is that PARALLEL_TESTS_EXECUTABLE is a parallel_tests thing that helps in environments where ruby needs to be run differently (like in ruby-core test setup), but the way it's implemented here it's replacing rspec, so the consumer of this library will need to include some command line to help running rspec in the ENV, right?

Yes. ruby-core need to use miniruby for testing bundler before ruby installation. The current implementation forces to use rspec by gem install or bundle install.

@ilyazub
Copy link
Collaborator

ilyazub commented Mar 7, 2025

@hsbt Thank you for all the work and for your kind words!

I agree with @deivid-rodriguez and prefer RSPEC_EXECUTABLE variable as it replaces bundle exec rspec.

I'll commit this change and merge this PR.

@ilyazub ilyazub merged commit ef03ee0 into serpapi:master Mar 7, 2025
10 checks passed
@hsbt hsbt deleted the support-env-executable branch March 10, 2025 01:06
@hsbt
Copy link
Contributor Author

hsbt commented Mar 10, 2025

@ilyazub Thanks for merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants