-
Notifications
You must be signed in to change notification settings - Fork 30
Handle fuubar #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Handle fuubar #51
Conversation
I had issues when using JSON formatter for extracting the number of total examples as suggested in #23 (comment) For example:
Any ideas ? |
56d29b3
to
6bfb97b
Compare
PR updated :
Changes are splitted in two commits :
|
One more thing : to use Fuubar, you need to require it in the command : bundle exec turbo_tests -r fuubar -f Fuubar spec/whatever |
6bfb97b
to
a5c8c77
Compare
The examples count code has been improved in main, such that I think this needs to be rebased and simplified. |
b61bc10
to
21cb9e6
Compare
PR rebased.
@pboling Did you mean reporter.rb#L77 from #48 ? Its seems that this methods returns the number of specs files while I keep calculating this number only when custom formatter are present because on large applications, it could take few seconds (See: #51 (comment)) |
Sorry, I no longer remember, and I'm not using this project currently. :( |
Fix #23 : Allow to use the Fuubar formatter.
This pull request depends on #41.
The changes from #41 could be seen inkstak/turbo_tests@feature-parallel_options...feature-handle_fuubar