Remove ArgumentConvert trait and implementations #3053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arqunis
added
enhancement
arqunis
approved these changes
Nov 22, 2024
|
Thinking about it, let's hold off merging this until poise@serenity-next doesn't fall apart catastrophically from this. That would probably need serenity-rs/poise#320 merged. |
arqunis
force-pushed
the
next
branch
2 times, most recently
from
57c79ff to
9a811a7
Compare
|
This should be unblocked now that serenity-rs/poise#357 is merged |
GnomedDev
force-pushed
the
remove-argumentconvert
branch
2 times, most recently
from
ffa4a08 to
8da2712
Compare
mkrasnitski
reviewed
Jul 19, 2025
GnomedDev
force-pushed
the
remove-argumentconvert
branch
from
8da2712 to
fe5f89d
Compare
mkrasnitski
approved these changes
Jul 25, 2025
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 28, 2025
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 28, 2025
BossFlea
added a commit
to BossFlea/serenity
that referenced
this pull request
Sep 20, 2025
This reverts commits: e5a4c30 "Remove ArgumentConvert trait and implementations (serenity-rs#3053)" bf79aa9 "Fix CacheUpdate implementations for extra FullEvents (serenity-rs#3066)"
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This historically was added for poise usage, but then poise still had to implement it's own trait which it uses when possible instead of this. Since this kind of logic is usually quite framework-specific let's get rid of it from serenity.