Fix CacheUpdate implementations for extra FullEvents #3066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cache
|
Blocked on #3053 for now. Don't feel like fixing code that's gonna get removed anyways. |
mkrasnitski
force-pushed
the
cache-update
branch
3 times, most recently
from
7547066 to
2dd5053
Compare
mkrasnitski
force-pushed
the
cache-update
branch
from
2dd5053 to
f1b4e98
Compare
mkrasnitski
force-pushed
the
cache-update
branch
2 times, most recently
from
e758fa6 to
9f19cbd
Compare
mkrasnitski
force-pushed
the
cache-update
branch
2 times, most recently
from
3cfd9a1 to
faa1aad
Compare
|
Since this is blocked on another PR, I am changing to draft. |
mkrasnitski
force-pushed
the
cache-update
branch
2 times, most recently
from
1adb5d2 to
358336e
Compare
mkrasnitski
force-pushed
the
cache-update
branch
2 times, most recently
from
2358db3 to
8e06740
Compare
mkrasnitski
force-pushed
the
cache-update
branch
from
8e06740 to
cdd90ee
Compare
mkrasnitski
force-pushed
the
cache-update
branch
from
cdd90ee to
efa9d8f
Compare
mkrasnitski
force-pushed
the
cache-update
branch
from
efa9d8f to
b41e9b5
Compare
mkrasnitski
force-pushed
the
cache-update
branch
2 times, most recently
from
dc9f5ed to
bac40f2
Compare
mkrasnitski
force-pushed
the
cache-update
branch
from
bac40f2 to
7548f7a
Compare
mkrasnitski
force-pushed
the
cache-update
branch
from
7548f7a to
15311a8
Compare
mkrasnitski
force-pushed
the
cache-update
branch
from
15311a8 to
4f57503
Compare
mkrasnitski
force-pushed
the
cache-update
branch
from
4f57503 to
34ca24a
Compare
mkrasnitski
force-pushed
the
cache-update
branch
from
01c4aa8 to
2290a77
Compare
mkrasnitski
force-pushed
the
cache-update
branch
from
2290a77 to
ebb20c3
Compare
mkrasnitski
force-pushed
the
cache-update
branch
2 times, most recently
from
43f8581 to
5c04af3
Compare
mkrasnitski
force-pushed
the
cache-update
branch
2 times, most recently
from
52caf10 to
48997a1
Compare
mkrasnitski
force-pushed
the
cache-update
branch
from
48997a1 to
8abf7b2
Compare
GnomedDev
approved these changes
Jul 26, 2025
| }, | ||
| Event::GuildDelete(mut event) => { | ||
| let full = if_cache!(event.update(cache)); | ||
| let full = if_cache!(update_cache!(cache, event)); |
There was a problem hiding this comment.
Why change this? I'm fine with merging as-is, just curious.
There was a problem hiding this comment.
Simply because update_cache! is used elsewhere in the file to do the same thing. Figured I'd make it consistent.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 28, 2025
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 28, 2025
BossFlea
pushed a commit
to BossFlea/serenity
that referenced
this pull request
Sep 16, 2025
BossFlea
added a commit
to BossFlea/serenity
that referenced
this pull request
Sep 16, 2025
…y-rs#3066)" to restore compatibility with poise This reverts commit bf79aa9.
BossFlea
added a commit
to BossFlea/serenity
that referenced
this pull request
Sep 20, 2025
This reverts commits: e5a4c30 "Remove ArgumentConvert trait and implementations (serenity-rs#3053)" bf79aa9 "Fix CacheUpdate implementations for extra FullEvents (serenity-rs#3066)"
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gateway was generating extra FullEvents by directly inspecting the contents of the cache, however this functionality can be incorporated as part of the
CacheUpdateimplementation for those events. The main cache fields are also private now. The temp_cache fields could be made private too, but I'm unsure if it's worth it.