Remove specialization hacks for PopArgument and SlashArgument
#357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the specialization of blanket impls with macro-generated impls for types that explicitly implement `serenity::ArgumentConvert`, and introduce a new `#[string]` attribute to signal that a type's `FromStr` implementation should be used.
Replaces hacky blanket impls with macro-generated impls for specific types, including some types that didn't have impls before, to line up with the list of types that implement `PopArgument`.
arqunis
approved these changes
Jul 11, 2025
|
Additional clippy failures are unrelated, so this PR is ready for merge. |
veronoicc
pushed a commit
to veronoicc/poise
that referenced
this pull request
Oct 7, 2025
…renity-rs#357) Replaces the specialization of blanket impls with macro-generated impls for types that explicitly implement `serenity::ArgumentConvert`, and introduce a new `#[string]` attribute to signal that a type's `FromStr` implementation should be used. Also replaces hacky blanket impls with macro-generated impls for specific types, including some types that did not have impls before, to line up with the list of types that implement `PopArgument`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #320. Replaces hacky blanket
impl {Pop,Slash}Argument for TwheneverT: ArgumentConvertandT: FromStrwith explicit implementations generated viamacro_rules!. One breaking change forPopArgumentis that types which do not implementArgumentConvertbut implementFromStrmust be decorated with a new#[string]attribute in order to generate the required parsing logic. Either that, or the user must implement the trait manually.We also keep the current logic for parsing IDs out of @-mentions.