-
-
Notifications
You must be signed in to change notification settings - Fork 60
Update for websockets 14.x and clean up asyncio #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Created custom_response function to allow the response to accept bytes type to have backword compatibility to server web pages via python server, of which is being handled by Nginx server now. Supperssing the ERROR logs by moving the loglevel to CRITIAL due to initial handshake error. But the log level can be changed with env SELKIES_WEBSOCKETS_LOG_LEVEL. Signed-off-by: PMohanJ <pmohan6712@gmail.com>
@ehfd I confirm this PR works with deb12 and websockets 14.2 in QBO See script to compile for Debian 12: https://github.com/alexeadem/selkies-gstreamer/tree/pr-171-deb12
Why Debian 12 instead of Ubuntu? Cause Kind images are maintained by the https://github.com/kubernetes-sigs/kind team and use systemd rather than supervisord |
Thanks for the information. Please have patience. |
Because I need to see how things work after merging, I am merging now and continuing on in |
Reference the issue numbers and reviewers
#170 @ehfd
Explain relevant issues and how this pull request solves them
Due to latest version release of websockets to 14.1 the current implementation requires refactoring to comply with the latest release
Describe the changes in code and its dependencies and justify that they work as intended after testing
Created custom_response function to allow the response to accept bytes type to have backword compatibility to server web pages via python server, of which is being handled by Nginx server now.
Describe alternatives you've considered
NA
Additional context
NA