Skip to content

self.loop break with websockets>11 #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexeadem opened this issue Feb 1, 2025 · 2 comments
Closed

self.loop break with websockets>11 #175

alexeadem opened this issue Feb 1, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@alexeadem
Copy link

Describe the bug

./src/selkies_gstreamer/signalling_web.py:108:        self.loop = loop
./src/selkies_gstreamer/signalling_web.py:477:        self.stop_server = self.loop.create_future()
./src/selkies_gstreamer/signalling_web.py:478:        async with websockets.serve(handler, self.addr, self.port, ssl=sslctx, process_request=http_handler, loop=self.loop,
./src/selkies_gstreamer/signalling_web.py:486:            asyncio.ensure_future(self.check_server_needs_restart(), loop=self.loop)
./src/selkies_gstreamer/webrtc_input.py:87:        self.loop = None
./src/selkies_gstreamer/webrtc_input.py:171:        assert self.loop is not None
./src/selkies_gstreamer/webrtc_input.py:181:        js = SelkiesGamepad(socket_path, self.loop)
./src/selkies_gstreamer/webrtc_input.py:184:        asyncio.ensure_future(js.run_server(), loop=self.loop)
./src/selkies_gstreamer/gamepad.py:179:        self.loop = loop
./src/selkies_gstreamer/gamepad.py:268:                await self.loop.sock_sendall(client, event)
./src/selkies_gstreamer/gamepad.py:283:            await self.loop.sock_sendall(client, config_data)
./src/selkies_gstreamer/gamepad.py:310:        self.loop.create_task(self.__send_events())
./src/selkies_gstreamer/gamepad.py:316:                    client, _ = await asyncio.wait_for(self.loop.sock_accept(self.server), timeout=1)

Tested with debian 12 and websockets<10 and we are back to normal

@alexeadem alexeadem added the bug Something isn't working label Feb 1, 2025
@ehfd
Copy link
Member

ehfd commented Feb 1, 2025

Addressed in conjunction to #170 #171

@ehfd ehfd added the high-priority Must be addressed as soon as possible, remove when resolved label Mar 21, 2025
@ehfd
Copy link
Member

ehfd commented Mar 23, 2025

Fixed in #171

@ehfd ehfd closed this as completed Mar 23, 2025
@ehfd ehfd removed the high-priority Must be addressed as soon as possible, remove when resolved label Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants