Skip to content

Conversation

@fruch
Copy link
Contributor

@fruch fruch commented Jun 10, 2025

Reverts #661

this change seems to be breaking some of the dtest gating

https://jenkins.scylladb.com/job/scylla-staging/job/dtest-pytest-gating/959/

we failed to test it before merging it, so now it's need to be reverted

@fruch fruch requested a review from denesb June 10, 2025 07:48
@denesb
Copy link
Contributor

denesb commented Jun 10, 2025

I though we run gating tests when merging CCM PRs.
Also, how come these were not failing during regular dtest gating test runs during CI and promotion? Was this commit never promoted to dtest's master?

@fruch
Copy link
Contributor Author

fruch commented Jun 10, 2025

I though we run gating tests when merging CCM PRs. Also, how come these were not failing during regular dtest gating test runs during CI and promotion? Was this commit never promoted to dtest's master?

This commit never reached dtest, i.e. someone needed to update the submodule
ccm is not part of next anymore.

The gating runs might have wrong run with a different ccm branch
We'll need to cross check

@fruch fruch merged commit 654e160 into master Jun 10, 2025
4 checks passed
@fruch
Copy link
Contributor Author

fruch commented Jun 10, 2025

I though we run gating tests when merging CCM PRs. Also, how come these were not failing during regular dtest gating test runs during CI and promotion? Was this commit never promoted to dtest's master?

This commit never reached dtest, i.e. someone needed to update the submodule ccm is not part of next anymore.

The gating runs might have wrong run with a different ccm branch We'll need to cross check

No on run the dtest gating, only ccm own CI, unit/integration tests were run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants