ccmlib/scylla_node.py: run_scylla_sstable(): dump sstables from a snapshot #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pshot When running scylla-sstable, sstables passed to the tool are prone to disappearing as a result of a concurrent compaction. To prevent this, callers are required to disable compaction on the table from which sstables are dumped. With tablets, new ways for sstables to disappear were introduced: migration, split and merge. Instead of piling on more responsibilities on the caller, ensure that sstables are stable during the dump internally: create a snapshot and dump the sstables from the snapshot. The snapshot is cleared after the dump, or left in place in case of error (for post-mortem analysis). If the caller doesn't provide a keyspace, or they provide a specific list of datafiles to be dumped, they still have to ensure that they are stable. After this change, the caller is still expected to keep schema tables non-compacting. This will be addressed in a future change. Fixes: scylladb/scylla-dtest#5866
denesb
force-pushed
the
run-scylla-sstable-snapshot
branch
from
0637b20 to
d0d8690
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running scylla-sstable, sstables passed to the tool are prone to disappearing as a result of a concurrent compaction. To prevent this, callers are required to disable compaction on the table from which sstables are dumped. With tablets, new ways for sstables to disappear were introduced: migration, split and merge. Instead of piling on more responsibilities on the caller, ensure that sstables are stable during the dump internally: create a snapshot and dump the sstables from the snapshot. The snapshot is cleared after the dump, or left in place in case of error (for post-mortem analysis).
If the caller doesn't provide a keyspace, or they provide a specific list of datafiles to be dumped, they still have to ensure that they are stable.
After this change, the caller is still expected to keep schema tables non-compacting. This will be addressed in a future change.
Fixes: scylladb/scylla-dtest#5866