Skip to content

Fix pagespeed insights accessibility issues #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

maltekuehl
Copy link
Collaborator

@maltekuehl maltekuehl commented Mar 17, 2025

Issues: https://pagespeed.web.dev/analysis/https-scverse-org/475tecsl9u?form_factor=mobile

Changes:

  • Specifies the document's language
  • Provides screenreader only label for the home link and makes the logo accessible
  • Improves contrast in the footer and improves semantics by moving headers out of lists
  • Makes the people list navigable by tab index while also showing the hover state with the details for the contributors

Accessibility at 100 with this PR: https://pagespeed.web.dev/analysis/https-deploy-preview-153--jade-cajeta-1bcca0-netlify-app/glkk08fpro?form_factor=mobile (disregard other metrics, as they are not reflective of real world performance in the Netlify preview).

Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for jade-cajeta-1bcca0 ready!

Name Link
🔨 Latest commit 6d7d274
🔍 Latest deploy log https://app.netlify.com/sites/jade-cajeta-1bcca0/deploys/67d8a11e2316a30008e1de95
😎 Deploy Preview https://deploy-preview-153--jade-cajeta-1bcca0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@maltekuehl maltekuehl requested a review from Zethson March 17, 2025 22:27
@Zethson Zethson requested review from gtca and removed request for gtca March 17, 2025 22:32
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@Zethson Zethson merged commit 2df4dcc into main Mar 17, 2025
6 checks passed
@Zethson Zethson deleted the pagespeed-insights-accessibility branch March 17, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants