Skip to content

Commit 2df4dcc

Browse files
authored
Fix pagespeed insights accessibility issues (#153)
* Fix pagespeed insights accessibility issues * Fix pagespeed insights accessibility issues
1 parent 24e1baa commit 2df4dcc

File tree

5 files changed

+22
-16
lines changed

5 files changed

+22
-16
lines changed

assets/main.scss

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ $navbgactive: $tilebg3;
3737

3838
$footerbg: #f0f0f0;
3939
$footertext: #333333;
40-
$footertextlight: #777777;
40+
$footertextlight: #555555;
4141
$footertextmuted: #aaaaaa;
4242

4343
$postlinktext: #333333;
@@ -723,10 +723,6 @@ body {
723723
color: $footertext;
724724
text-align: left;
725725

726-
ul {
727-
list-style: none;
728-
}
729-
730726
a,
731727
p {
732728
margin: 0.2rem 0;
@@ -917,6 +913,7 @@ body {
917913
.post-content {
918914
margin: 3rem 0;
919915
font-size: 1.1rem;
916+
text-wrap: pretty;
920917
span.backticked {
921918
font-size: 1.2rem;
922919
line-height: 1.1rem;
@@ -1199,12 +1196,14 @@ body {
11991196
width: 100%;
12001197
}
12011198

1202-
.team-member:hover .person-chip {
1199+
.team-member:hover .person-chip,
1200+
.team-member:focus-within .person-chip {
12031201
background-color: var(--tilebg2, #e5e5e5);
12041202
color: var(--tiletext3, #000);
12051203
}
12061204

1207-
.team-member:has(.additional-info):hover .person-chip {
1205+
.team-member:has(.additional-info):hover .person-chip,
1206+
.team-member:has(.additional-info):focus-within .person-chip {
12081207
border-radius: 0.5rem 0.5rem 0 0;
12091208
}
12101209

@@ -1222,7 +1221,8 @@ body {
12221221
width: 100%;
12231222
}
12241223

1225-
.team-member:hover .additional-info {
1224+
.team-member:hover .additional-info,
1225+
.team-member:focus-within .additional-info {
12261226
visibility: visible;
12271227
}
12281228

layouts/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!doctype html>
2-
<html>
2+
<html lang="en">
33
<head>
44
{{ partial "head" . }}
55
</head>

layouts/partials/footer.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
<div id="footer-content" class="container">
33
<div class="row">
44
<div class="col-12 col-md-6 col-lg-3">
5-
<ul>
6-
<h5>Pages</h5>
5+
<h5>Pages</h5>
6+
<ul class="list-unstyled">
77
<li><a href="/packages">Packages</a></li>
88
<li><a href="/learn">Learn</a></li>
99
<li><a href="/people">People</a></li>
@@ -13,16 +13,16 @@ <h5>Pages</h5>
1313
</ul>
1414
</div>
1515
<div class="col-12 col-md-6 col-lg-3">
16-
<ul>
17-
<h5>Governance</h5>
16+
<h5>Governance</h5>
17+
<ul class="list-unstyled">
1818
<li><a href="/about/mission/">Mission statement</a></li>
1919
<li><a href="/about/code_of_conduct">Code of conduct</a></li>
2020
<li><a href="/about/roles">Roles</a></li>
2121
</ul>
2222
</div>
2323
<div class="col-12 col-md-6 col-lg-3">
24-
<ul>
25-
<h5>Join scverse</h5>
24+
<h5>Join scverse</h5>
25+
<ul class="list-unstyled">
2626
<li><a href="https://github.com/scverse" target="_blank">GitHub</a></li>
2727
<li><a href="https://discourse.scverse.org/" target="_blank">Discourse</a></li>
2828
<li><a href="https://scverse.zulipchat.com/" target="_blank">Zulip</a></li>

layouts/partials/header.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
<div class="container-fluid">
44
<a class="navbar-brand row align-items-center m-0" href="/">
55
<div id="scverse-logo" class="col"></div>
6+
<span class="visually-hidden">scverse</span>
67
<!--{{ if ne .Section `` }}
78
<span class="logo-name col m-0 px-3">scverse</span>
89
{{ end }}-->

layouts/partials/main/packages.html

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,12 @@
1111
<img src="img/icons/{{ .name }}.svg" alt="Logo for {{ .name }}" />
1212
</div>
1313
<div class="card-body package-text p-2">
14-
<a href="{{ .url }}" class="stretched-link" target="_blank" onclick=""></a>
14+
<a
15+
href="{{ .url }}"
16+
class="stretched-link"
17+
target="_blank"
18+
aria-label="Link to the {{ .name }} website"
19+
></a>
1520
<h5 class="card-title mb-1 package-name">
1621
{{ .name }}
1722
</h5>

0 commit comments

Comments
 (0)