Skip to content

bump n5-ij, n5-viewer, bigwarp #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2024
Merged

Conversation

bogovicj
Copy link
Contributor

@bogovicj bogovicj commented Oct 4, 2024

  • should address mega-melt issues

bogovicj and others added 4 commits October 4, 2024 16:42
* should address mega-melt issues
The needed fix is part of n5-aws-s3 v4.0.0, released in July 2023.
We do this to avoid CI-specific failures. All seems well locally.
@ctrueden
Copy link
Member

ctrueden commented Oct 6, 2024

The good news: n5-viewer and bigwarp passed! The bad news: n5-ij still failed ☹️

Error:  Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.153 s <<< FAILURE! -- in org.janelia.saalfeldlab.n5.metadata.ome.ngff.v04.WriteAxesTests
Error:  org.janelia.saalfeldlab.n5.metadata.ome.ngff.v04.WriteAxesTests.testXYT -- Time elapsed: 0.024 s <<< ERROR!
java.util.NoSuchElementException: No value present
    at java.util.Optional.get(Optional.java:135)
    at org.janelia.saalfeldlab.n5.metadata.ome.ngff.v04.WriteAxesTests.readImage(WriteAxesTests.java:284)
    at org.janelia.saalfeldlab.n5.metadata.ome.ngff.v04.WriteAxesTests.testXYT(WriteAxesTests.java:158)

See also discussion on this Zulip thread. I pushed an exclusion to the mega-melt test for the n5-ij tests, so that we can proceed with the pom-scijava upgrade.

@ctrueden ctrueden merged commit 6a0161f into scijava:master Oct 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants