software_center_download: Improved logic for skipping existing files and getting valid filename

[marcelmamula]

Description

Module software_center_download and its supporting plugins were updated to improve handling:

Similar files was not skipping when files were present

Issue

Pattern for similar files was not working correctly and it was not recognizing file extensions.

Solution

Function _check_similar_files was enhanced to follow this logic:

1. Function is executed only if file with exact name is not found
2. If filename has extension, then search for similar files without considering extension.
3. If filename has no extension, then search for filename + any extension.

Function for updating filename from description was not working well for database files

Issue

Database files contain description with empty spaces, resulting in broken Linux commands during sap_install_media_detect role execution.
Example:
changed: [e04nwas] => (item=51057961_1 : Successfully downloaded SAP software: SAP ASE 16.0.04.06 HF1 RDBMS Linux on x86_64 64bit)

Solution

Function _get_valid_filename will now execute only for purely numerical filenames and it will use Description only if it is present and does not contain empty spaces.

[sean-freeman]

Verified code, lgtm 👍