Skip to content

Update Rust Toolchain to 1.80.1 #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

roypat
Copy link
Member

@roypat roypat commented Aug 12, 2024

With toolchain version >= 1.80 some crates had regressions due to stricter file descriptor ownership tracking in the standard library (e.g. tracking the same fd in multiple File objects, and thus resulting in multiple close calls for the same fd will now cause panics in the drop impl). We started getting fix-up PRs (rust-vmm/kvm#272), so update the CI to 1.80.1 to make sure we don't regress again after merging fixes.

Summary of the PR

Please summarize here why the changes in this PR are needed.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

Apparently 1.80 breaks some things and we started getting fix-up PRs
(kvm-ioctls#272). Update the CI to 1.80.1 to make sure we don't regress
again after merging fixes.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@stefano-garzarella stefano-garzarella merged commit 3bdd9bb into rust-vmm:main Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants