Fix IO safety runtime errors in tests #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssais
requested review from
acatangiu,
alxiord,
andreeaflorescu,
lauralt,
sameo,
roypat and
ShadowCurse
as code owners
If debug_assertions is enabled, Rust 1.80.0 and later will abort the process when attempting to close a file descriptor that is already closed[1]. This means that, in tests, where an invalid file descriptor object is deliberately constructed, we have to avoid that object being dropped. Using into_raw_fd() allows the object's memory to be freed (unlike std::mem::forget()), without attempting to close the file descriptor. [1]: rust-lang/rust@cb49406 Signed-off-by: Alyssa Ross <hi@alyssa.is>
roypat
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Thanks for this! I'm using this as an opportunity to also update our CI toolchain to 1.80.1 (rust-vmm/rust-vmm-container#111) so that we (a) don't regress on these again, and (b) potentially find and fix other issues before downstream users discover them :)
ShadowCurse
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
If debug_assertions is enabled, Rust 1.80.0 and later will abort the process when attempting to close a file descriptor that is already closed. This means that, in tests, where an invalid file descriptor object is deliberately constructed, we have to avoid that object being dropped. Using
into_raw_fd()allows the object's memory to be freed (unlikestd::mem::forget()), without attempting to close the file descriptor.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.