-
Notifications
You must be signed in to change notification settings - Fork 1
Redux Tests #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redux Tests #7
Conversation
…d avoid a bug if setItem with false explicit
@CYBAI please check AllenFang@86d55e9 and AllenFang@0844659 I only have this two commit in my fork, and this both commits is for using Something need discuss:
Please let me know your concern, it's just a experiment and we dont must use it but if we want to use this, I can base this two commits to create another PR. Thanks |
BTW, The test of reducers are done, please review. |
Thanks. |
It seems a good idea to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test part LGTM.
Could you help to add .travis.yml
to trigger testing?
Merge this PR first, have to fix |
Use
redux-api-middleware
instead ofredux-thunk