Fix type error cannot read property async #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CYBAI, please review, seems like Travis was pass now. |
CYBAI
requested changes
Jun 27, 2017
|
|
||
| import { FETCH_HEADER } from '../../utils/constants'; |
There was a problem hiding this comment.
Can we require util without dots?
ex. import { FETCH_HEADER } from 'utils/constants'
CYBAI
approved these changes
Jun 29, 2017
AllenFang
force-pushed
the
fix-TypeError-Cannot-read-property-async
branch
from
6aae566 to
364e3b1
Compare
|
@CYBAI, I revert the lastest commit about resolving "moduleDirectories": [ 'node_modules', 'src-react/__test__' ]But it most like cause a import naming conflict for You can imagine this line and guess what module will be imported?!. I try to avoid it bug but still fails, and also I think it's not very important that must handle this relative path in testing code, Please give some useful solution if you have, thanks |
|
@AllenFang Okay, if I have better solution for this, I'll discuss with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #7 (comment)