-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Adds a shared pipeline for gems verify workflow #20001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a shared pipeline for gems verify workflow #20001
Conversation
be6ff3d
to
f7b2c92
Compare
a68e8ea
to
cabf58f
Compare
Just an opinion here, this seems to create a circular dependency in the github actions where sub-gems repos are now dependent on the state of a repo that consumes them. It might be better to create a repo that holds |
a2b230c
to
ea63928
Compare
86698c3
to
afa30d0
Compare
@jmartin-tech Thanks! I also think having it in a centralized repo could also reduce the checkout time for faster CI runs by a bit, but we'll keep things simple as a first pass and can revisit it if there's any issues with future upgrade efforts 🤞 |
afa30d0
to
81aa4be
Compare
This PR adds two new shared pipelines for testing gems. One for testing gems with Rails and another for without. The idea here was to now have one centralized point of truth for testing our gems.
The shared pipeline will support inputs for dependencies and testing commands e.g.
Initially the corresponding gem PRs will point at these new pipelines on my @cgranleese-r7 repository for testing. Once this is landed, I will rebase those PRs.
Gems PRs:
Verification