Updates verify workflow to use shared pipeline #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranleese-r7
force-pushed
the
updates-verify-workflow-to-use-shared-pipeline
branch
from
a6fd0e1 to
cc9335d
Compare
2 tasks
cgranleese-r7
force-pushed
the
updates-verify-workflow-to-use-shared-pipeline
branch
2 times, most recently
from
bd9f7c6 to
c147b53
Compare
adfoster-r7
reviewed
Apr 3, 2025
adfoster-r7
reviewed
Apr 3, 2025
| build: | ||
| uses: cgranleese-r7/metasploit-framework/.github/workflows/shared_gem_verify_rails.yml@add-gem-verify-shared-pipeline | ||
| with: | ||
| dependencies: '["libpcap-dev", "graphviz"]' |
There was a problem hiding this comment.
Not a blocker; This probably won't scale well if we do support osx/windows boxes in the future
cgranleese-r7
force-pushed
the
updates-verify-workflow-to-use-shared-pipeline
branch
23 times, most recently
from
c69c566 to
25c881c
Compare
cgranleese-r7
commented
Apr 4, 2025
cgranleese-r7
force-pushed
the
updates-verify-workflow-to-use-shared-pipeline
branch
13 times, most recently
from
ae37f19 to
3b93df2
Compare
2 tasks
cgranleese-r7
force-pushed
the
updates-verify-workflow-to-use-shared-pipeline
branch
from
3b93df2 to
7311dd9
Compare
cgranleese-r7
force-pushed
the
updates-verify-workflow-to-use-shared-pipeline
branch
from
7311dd9 to
c4eef97
Compare
This was referenced Apr 9, 2025
adfoster-r7
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates this workflow to make use off the shared pipeline added as part of rapid7/metasploit-framework#20001.
Initially this PR will point at these new pipelines on my @cgranleese-r7 repository for testing. Once this is landed, I will rebase this PR.
Related PRs:
Ruby 3.4
I also some dependenices to the gemspec as it is not part of the default gems starting from Ruby 3.4.0(https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/). This can be pulled out into another PR if that is preferred.
Verification