-
Notifications
You must be signed in to change notification settings - Fork 4
ci: Add new example chart meant for testing and QA #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ca6f8a to
67d0c1a
Compare
215fef2 to
c179a94
Compare
a12166d to
047714f
Compare
Member
Author
|
Closing in favor of: #117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per title, this adds a new chart for testing this image standalone from other charts.
The benefit of this is that our QA teams can focus specifically on this image when we work on releases for it. This untangles us from potential complications related to shipping RC versions of this image into other projects.
So by isolating the RC testing and QA process of this project within itself - while replicating the actions other charts will make - we can have the flexibility of not being dependent on a specific chart for testing, while ensuring that the testing we do is an accurate reflection of the charts that will use the image.
Issues Being Addressed
Platform Mismatch of Image and Binary
This happened due to an upstream bug that I didn't catch sooner, I added a tool for verifying this but it's only useful after an image is pushed to a registry. CI needs to happen (and fail if needed) before a push happens so that's not good enough.
TODO:
kubectl-testchart provided,helm-packagestyle command for this repo,Example of Issues:
Platform Mismatch of Image and Binary
This can be replicated with version
v4.0.1or earlier as this was fixed in v4.0.2. So to replicate an error (and prove the CI script works):Upon running that verify command it will use the known broken OCI image and you will see the ARM arch image fail with: