-
Notifications
You must be signed in to change notification settings - Fork 4
[ci] Add new example chart meant for testing and QA #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
…se it for CI scripts too
427925a to
9192c66
Compare
9192c66 to
538e069
Compare
alexandreLamarre
approved these changes
Jul 25, 2025
Member
Author
|
/backport release/v4.x |
Contributor
|
Not creating port PR, there was an error running git am -3: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #98
In order to expand the testing done to this project before PRs are merged I've added a very basic E2E testing suite (based on PromFed project's tooling). This along with the other CI tooling has us covered for the most basic of tests. These are:
Any more specific testing (replicating chart upgrade jobs/etc) should be implemented later in a follow up effort. This is because that style of testing is most relevant to the charts using this image for that action and those charts are the ones that define the job/deployment. The only requirement of this image for that is that the image exists and has the kuberlr and kubectl binaries.
In other words, the e2e scripts should be expanded to cover executing those test-cases based on what makes sense. This is not easy to accomplish with a single chart, so that's why it was excluded from this PR effort. They however would fit better as one-off deployments (outside of helm) as static manifests and then verifying those had expected results.
Backports
This should be backported to the current release branches too.
This is a cleaned up version of: #91