Skip to content

Make sure InMemorySessionManager stores session before notifying listeners #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

manovotn
Copy link
Contributor

I came across this when re-visiting quarkusio/quarkus#46363 and I believe this is the correct fix for it.

That being said, I am not sure what other parts of Quarkus (or user code?) might possibly rely on the current ordering of listener notification versus session storage.
@gsmet any idea what should I check? Obviously I tried the Undertow tests in Quarkus repo but that feels a little insufficient.

Also cc @mkouba as you were at least vaguely aware of the original issue :)

This comment has been minimized.

Copy link

quarkus-bot bot commented May 22, 2025

Status for workflow Build

This is the status report for running Build on commit 3745984.

Failing Jobs

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Failures Logs Raw logs
Build - JDK 17 ⚠️ Check → Logs Raw logs
✔️ Build - JDK 21 Logs Raw logs

@manovotn
Copy link
Contributor Author

The CI failure is very unlikely to be related:

The hosted runner: GitHub Actions 45 lost communication with the server.

Although it did fail again on rerun 🤷

@gsmet gsmet merged commit 106838d into quarkusio:main May 26, 2025
2 of 3 checks passed
@manovotn manovotn deleted the storeSessionBeforeListenerNotification branch May 27, 2025 01:35
@manovotn
Copy link
Contributor Author

Even with a release, you are lightning fast @gsmet, thank you!
I'll send a PR to Quarkus tomorrow along with the test case I had for the original issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants