-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update quarkus-http, create test coverage for Undertow session context events #48083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quarkus-http, create test coverage for Undertow session context events #48083
Conversation
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just wondering if we maybe wanna assert that session-scoped beans cannot observe @Destroyed(SessionScoped.class)
?
Except that it's not exactly defined what happens if an observer method is invoked and the relevant context is not active 🤔... |
You mean when the event is fired? I'm thinking the observer method should not be called at all. But if it's more complex than what I imagine, then let's leave it :-) |
I am not sure we test this for any other scope but TBF it doesn't make sense to me - we always deactivate context and then fire the event. And that is the only sensible order of actions to me so I see such test as completely redundant...but maybe I am missing something 🤷
I agree, and that is what Weld does too. |
And ArC does the same since 3.0.0.Final. |
@mkouba do you then agree to keep this PR as is or should I change something? |
I do agree. |
The idea is to enable
@SessionScoped
beans to observe its own@Initialized
and@BeforeDestroyed
events (which they should be able to according to the specification).The fix itself is in
quarkus-http
, see quarkusio/quarkus-http#174Fixes #46363