Skip to content

feat(deps): Migration to Quarkus 3.20.0 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,16 @@
package io.quarkiverse.kafkastreamsprocessor.sample.multioutput;

import io.quarkus.test.junit.QuarkusIntegrationTest;
import io.quarkus.test.junit.QuarkusTestProfile;
import io.quarkus.test.junit.TestProfile;

@QuarkusIntegrationTest
@TestProfile(PingProcessorIT.TestProfile.class)
public class PingProcessorIT extends PingProcessorQuarkusTest {
public static class TestProfile implements QuarkusTestProfile {
@Override
public String getConfigProfile() {
return "test";
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,16 @@
package io.quarkiverse.kafkastreamsprocessor.sample.simple;

import io.quarkus.test.junit.QuarkusIntegrationTest;
import io.quarkus.test.junit.QuarkusTestProfile;
import io.quarkus.test.junit.TestProfile;

@QuarkusIntegrationTest
@TestProfile(PingProcessorIT.TestProfile.class)
public class PingProcessorIT extends PingProcessorQuarkusTest {

public static class TestProfile implements QuarkusTestProfile {
@Override
public String getConfigProfile() {
return "test";
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,16 @@
package io.quarkiverse.kafkastreamsprocessor.sample.stateful;

import io.quarkus.test.junit.QuarkusIntegrationTest;
import io.quarkus.test.junit.QuarkusTestProfile;
import io.quarkus.test.junit.TestProfile;

@QuarkusIntegrationTest
@TestProfile(PingProcessorIT.TestProfile.class)
public class PingProcessorIT extends PingProcessorQuarkusTest {
public static class TestProfile implements QuarkusTestProfile {
@Override
public String getConfigProfile() {
return "test";
}
}
}
6 changes: 3 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>io.quarkiverse</groupId>
<artifactId>quarkiverse-parent</artifactId>
<version>18</version>
<version>20</version>
</parent>
<groupId>io.quarkiverse.kafkastreamsprocessor</groupId>
<artifactId>quarkus-kafka-streams-processor-parent</artifactId>
Expand All @@ -28,12 +28,12 @@
<tag>HEAD</tag>
</scm>
<properties>
<compiler-plugin.version>3.13.0</compiler-plugin.version>
<compiler-plugin.version>3.14.0</compiler-plugin.version>
<!-- NB: JDK 17 is required by spring-kafka-test at build time -->
<maven.compiler.release>17</maven.compiler.release>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<quarkus.version>3.15.3</quarkus.version>
<quarkus.version>3.20.0</quarkus.version>

<protobuf.version>3.25.5</protobuf.version>
</properties>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public Map<String, String> start() {
@Override
public void stop() {
try {
FileUtils.forceDelete(tmpDir);
FileUtils.forceDeleteOnExit(tmpDir);
} catch (Exception e) {
throw new RuntimeException("error deleting " + tmpDir, e);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@
import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.hasEntry;
import static org.junit.jupiter.api.Assertions.assertFalse;

import java.io.File;
import java.util.Map;

import org.junit.jupiter.api.Test;
Expand All @@ -40,8 +38,6 @@ void createsTempDirAndDeletesIt() {
assertThat(props, hasEntry(equalTo("kafka-streams.state.dir"), containsString("kstreamstateful")));

resource.stop();

assertFalse(new File(props.get("kafka-streams.state.dir")).exists());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so why we removed this one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a remove on JVM exit, as in windows the rockdb lock is kept too long for the deletion to be done immediatly. At the time of running this assert the directory is not yet removed, i.e. it will fail.

}

}