feat(deps): Migration to Quarkus 3.20.0 #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annlazar
force-pushed
the
migration-quarkus-3.20
branch
from
2646e8e to
f94d0ab
Compare
csemaan1A
reviewed
May 20, 2025
| @@ -40,8 +38,6 @@ void createsTempDirAndDeletesIt() { | |||
| assertThat(props, hasEntry(equalTo("kafka-streams.state.dir"), containsString("kstreamstateful"))); | |||
|
|
|||
| resource.stop(); | |||
|
|
|||
| assertFalse(new File(props.get("kafka-streams.state.dir")).exists()); | |||
There was a problem hiding this comment.
so why we removed this one?
There was a problem hiding this comment.
We need a remove on JVM exit, as in windows the rockdb lock is kept too long for the deletion to be done immediatly. At the time of running this assert the directory is not yet removed, i.e. it will fail.
csemaan1A
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161.
Update #162.
Fix integration tests.
Update FileUtils.forceDelete to forceDeleteOnExit to be able to build in Windows
Co-authored-by: edeweerd emile.deweerd@amadeus.com