migrate etrecord generation after to_edge_transform_and_lower to new infra #13058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…infra Differential Revision: [D79420502](https://our.internmc.facebook.com/intern/diff/D79420502/) [ghstack-poisoned]
Gasoonjia
requested review from
cccclai,
digantdesai,
mcr229 and
metascroy
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13058
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New Failures, 1 Unrelated FailureAs of commit 3652afd with merge base 981119e ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 31, 2025
meta-cla
bot
added
the
CLA Signed
Gasoonjia
added a commit
that referenced
this pull request
Aug 1, 2025
…infra Differential Revision: [D79420502](https://our.internmc.facebook.com/intern/diff/D79420502/) ghstack-source-id: 300044629 Pull Request resolved: #13058
This PR needs a
|
|
This pull request was exported from Phabricator. Differential Revision: D79420502 |
digantdesai
reviewed
Aug 1, 2025
examples/xnnpack/aot_compiler.py
Outdated
| _check_ir_validity=False if args.quantize else True, | ||
| _skip_dim_order=True, # TODO(T182187531): enable dim order in xnnpack | ||
| ), | ||
| generate_etrecord=args.etrecord is not None, |
There was a problem hiding this comment.
Add default as False above
Suggested change
| generate_etrecord=args.etrecord is not None, | |
| generate_etrecord=args.etrecord is not False, |
digantdesai
approved these changes
Aug 1, 2025
…wer to new infra" Differential Revision: [D79420502](https://our.internmc.facebook.com/intern/diff/D79420502/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Aug 1, 2025
…infra Pull Request resolved: #13058 this diff migrates the infra for etrecrod generation in to_edge_transform_and_lower flow to latest one. Differential Revision: [D79420502](https://our.internmc.facebook.com/intern/diff/D79420502/) ghstack-source-id: 300167042
|
This pull request was exported from Phabricator. Differential Revision: D79420502 |
…wer to new infra" Differential Revision: [D79420502](https://our.internmc.facebook.com/intern/diff/D79420502/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Aug 5, 2025
…infra Pull Request resolved: #13058 this diff migrates the infra for etrecrod generation in to_edge_transform_and_lower flow to latest one. ghstack-source-id: 300740657 Differential Revision: [D79420502](https://our.internmc.facebook.com/intern/diff/D79420502/)
|
This pull request was exported from Phabricator. Differential Revision: D79420502 |
…wer to new infra" Differential Revision: [D79420502](https://our.internmc.facebook.com/intern/diff/D79420502/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Aug 5, 2025
…infra Pull Request resolved: #13058 this diff migrates the infra for etrecrod generation in to_edge_transform_and_lower flow to latest one. ghstack-source-id: 300961294 Differential Revision: [D79420502](https://our.internmc.facebook.com/intern/diff/D79420502/)
|
This pull request was exported from Phabricator. Differential Revision: D79420502 |
This was referenced Aug 5, 2025
facebook-github-bot
merged commit a880d63
into
gh/gasoonjia/34/base
99 of 105 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
Gasoonjia
added a commit
that referenced
this pull request
Aug 6, 2025
…infra (#13153) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #13058 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/34/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/34/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/34/orig @diff-train-skip-merge Differential Revision: D79420502 Co-authored-by: gasoonjia <gasoonjia@icloud.com> Co-authored-by: Gasoonjia <gasoonjia@meta.com>
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
…infra (pytorch#13153) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#13058 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/34/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/34/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/34/orig @diff-train-skip-merge Differential Revision: D79420502 Co-authored-by: gasoonjia <gasoonjia@icloud.com> Co-authored-by: Gasoonjia <gasoonjia@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D79420502