make etrecord set representive IO #13052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
representive input and reference output in etrecord will not be set during export flow. To continue supporting the two functionalities, this diff creates two class methods to customize IO in etrecord. Differential Revision: [D79386896](https://our.internmc.facebook.com/intern/diff/D79386896/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13052
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New Failures, 1 Unrelated FailureAs of commit 2273faa with merge base 964a57a ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 31, 2025
meta-cla
bot
added
the
CLA Signed
Gasoonjia
added a commit
that referenced
this pull request
Jul 31, 2025
representive input and reference output in etrecord will not be set during export flow. To continue supporting the two functionalities, this diff creates two class methods to customize IO in etrecord. Differential Revision: [D79386896](https://our.internmc.facebook.com/intern/diff/D79386896/) ghstack-source-id: 299959749 Pull Request resolved: #13052
|
This pull request was exported from Phabricator. Differential Revision: D79386896 |
This PR needs a
|
representive input and reference output in etrecord will not be set during export flow. To continue supporting the two functionalities, this diff creates two class methods to customize IO in etrecord. Differential Revision: [D79386896](https://our.internmc.facebook.com/intern/diff/D79386896/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79386896 |
digantdesai
reviewed
Aug 1, 2025
| else: | ||
| self._representative_inputs = representative_inputs | ||
|
|
||
| def update_reference_outputs( |
There was a problem hiding this comment.
Nit: why not a single API? Is there a need to use these individually and not together?
representive input and reference output in etrecord will not be set during export flow. To continue supporting the two functionalities, this diff creates two class methods to customize IO in etrecord. Differential Revision: [D79386896](https://our.internmc.facebook.com/intern/diff/D79386896/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79386896 |
JacobSzwejbka
approved these changes
Aug 1, 2025
representive input and reference output in etrecord will not be set during export flow. To continue supporting the two functionalities, this diff creates two class methods to customize IO in etrecord. Differential Revision: [D79386896](https://our.internmc.facebook.com/intern/diff/D79386896/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79386896 |
facebook-github-bot
merged commit f084c9a
into
gh/gasoonjia/33/base
101 of 105 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
Gasoonjia
added a commit
that referenced
this pull request
Aug 5, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #13052 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/33/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/33/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/33/orig @diff-train-skip-merge Differential Revision: D79386896 Co-authored-by: gasoonjia <gasoonjia@icloud.com> Co-authored-by: Gasoonjia <gasoonjia@meta.com>
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#13052 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/33/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/33/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/33/orig @diff-train-skip-merge Differential Revision: D79386896 Co-authored-by: gasoonjia <gasoonjia@icloud.com> Co-authored-by: Gasoonjia <gasoonjia@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
representive input and reference output in etrecord will not be set during export flow. To continue supporting the two functionalities, this diff creates two class methods to customize IO in etrecord.
Differential Revision: D79386896