Skip to content

Backend data separation test #10531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh/lucylq/71/base
Choose a base branch
from
Open

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Apr 28, 2025

Stack from ghstack (oldest at bottom):

Add backend data separation test with demo ExecutorBackend.

Note: ExecutorBackend is a wrapper around a portable PTE file. It doesn't support delegated program-data separation in the sense of tagging tensors as external and placing them into the named data store as such. Rather, this test:

  1. Creates a linear PTE file with data removed, using the portable flow.
  2. Packages (1) into preprocessed blob as a delegate, using ExecutorBackend. Note: this discards the PTD portion.
  3. Re-create the PTD portion via export_program (portable flow again).
  4. Runs the delegated ExecutorBackend linear with portable linear.ptd file.

Caveat: this means that LinearModule definition in export_program and export_delegated_program must stay in sync, as we get the PTE artifact from export_delegated_program (wrapped in ExecutorBackend), and the PTD artifact from export_program.

Differential Revision: D73679733

Add backend data separation test with demo ExecutorBackend.

Note: ExecutorBackend is a wrapper around a portable PTE file. It doesn't support delegated program-data separation in the sense of tagging tensors as external and placing them into the named data store as such. Rather, this test:

1. Creates a linear PTE file with data removed, using the portable flow.
2. Packages (1) into preprocessed blob as a delegate, using ExecutorBackend. Note: this discards the PTD portion.
3. Re-create the PTD portion via export_program (portable flow again).
4. Runs the delegated ExecutorBackend linear with portable linear.ptd file.

Caveat: this means that LinearModule definition in export_program and export_delegated_program must stay in sync, as we get the PTE artifact from export_delegated_program (wrapped in ExecutorBackend), and the PTD artifact from export_program.

Differential Revision: [D73679733](https://our.internmc.facebook.com/intern/diff/D73679733/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Apr 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10531

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 1 Unrelated Failure

As of commit bb9fa67 with merge base df75088 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 28, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73679733

Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants