Skip to content

Pass one NDM to backend init #10528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: gh/lucylq/69/base
Choose a base branch
from
Open

Pass one NDM to backend init #10528

wants to merge 8 commits into from

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Apr 28, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.

Differential Revision: D73679710

@lucylq
Pass one NDM to backend init
98b386c 
Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)

[ghstack-poisoned]
@lucylq lucylq mentioned this pull request Apr 28, 2025
Open
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10528

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 5a5bac5 with merge base 4524838 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

lucylq added a commit that referenced this pull request Apr 28, 2025
@lucylq
Pass one NDM to backend init
af726cd 
Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)

ghstack-source-id: 280710106
Pull Request resolved: #10528
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 28, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73679710

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JacobSzwejbka
JacobSzwejbka requested changes Apr 28, 2025
View reviewed changes
This was referenced Apr 28, 2025
Open
Open
Open
@lucylq
Update on "Pass one NDM to backend init"
c90d4e5 
Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 28, 2025
@lucylq
Pass one NDM to backend init
a796485 
Pull Request resolved: #10528

Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.
ghstack-source-id: 280808267

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73679710

@lucylq lucylq requested a review from JacobSzwejbka April 28, 2025 23:59
@lucylq
Update on "Pass one NDM to backend init"
67a331b 
Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 29, 2025
@lucylq
Pass one NDM to backend init
1c8d07d 
Pull Request resolved: #10528

Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.
ghstack-source-id: 281044605

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73679710

@lucylq
Update on "Pass one NDM to backend init"
da7cc18 
Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 30, 2025
@lucylq
Pass one NDM to backend init
fb44439 
Pull Request resolved: #10528

Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.
ghstack-source-id: 281074087

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73679710

@lucylq
Update on "Pass one NDM to backend init"
2c6d0f8 
Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 30, 2025
@lucylq
Pass one NDM to backend init
ddb905b 
Pull Request resolved: #10528

Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.
ghstack-source-id: 281074087

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73679710

@lucylq
Update on "Pass one NDM to backend init"
4400818 
Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 30, 2025
@lucylq
Pass one NDM to backend init
9895933 
Pull Request resolved: #10528

Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.
ghstack-source-id: 281201577

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73679710

@lucylq
Update on "Pass one NDM to backend init"
d42f4ef 
Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 30, 2025
@lucylq
Pass one NDM to backend init
420f797 
Pull Request resolved: #10528

Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.
ghstack-source-id: 281215638

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73679710

@lucylq
Update on "Pass one NDM to backend init"
5a5bac5 
Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 30, 2025
@lucylq
Pass one NDM to backend init
333b729 
Pull Request resolved: #10528

Take external NDM if it exists, otherwise internal.

Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.
ghstack-source-id: 281215638

Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73679710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucylq @facebook-github-bot @JacobSzwejbka