Skip to content

[monarch] monarch.actor submodule #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

suo
Copy link
Contributor

@suo suo commented Jul 6, 2025

Stack from ghstack (oldest at bottom):

This is the proposed monarch.actor submodule.

The public API is just a flat namespace, determined by monarch/actor/__init__.py.

Everything else is a private detail, signified by lots of underscores in filenames. That's a little unforunate, but I think draws some good boundaries, and keeps the API simple to the user.

Some principles that should guide us moving forward:

  • Every symbol has at most two locations: a private location (which should be exactly the same as its location in the source tree), and optionally a public location in the user-facing API.
  • We discourage end-users from depending on private locations via underscores, per python convention.

Differential Revision: D77709116

This is the proposed `monarch.actor` submodule.

The public API is just a flat namespace, determined by `monarch/actor/__init__.py`.

*Everything else* is a private detail, signified by lots of underscores in filenames. That's a little unforunate, but I think draws some good boundaries, and keeps the API simple to the user.

Some principles that should guide us moving forward:
- **Every symbol has at most two locations**: a private location (which should be exactly the same as its location in the source tree), and optionally a public location in the user-facing API.
- We discourage end-users from depending on private locations via underscores, per python convention.

Differential Revision: [D77709116](https://our.internmc.facebook.com/intern/diff/D77709116/)

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 6, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77709116

This is the proposed `monarch.actor` submodule.

The public API is just a flat namespace, determined by `monarch/actor/__init__.py`.

*Everything else* is a private detail, signified by lots of underscores in filenames. That's a little unforunate, but I think draws some good boundaries, and keeps the API simple to the user.

Some principles that should guide us moving forward:
- **Every symbol has at most two locations**: a private location (which should be exactly the same as its location in the source tree), and optionally a public location in the user-facing API.
- We discourage end-users from depending on private locations via underscores, per python convention.

Differential Revision: [D77709116](https://our.internmc.facebook.com/intern/diff/D77709116/)

[ghstack-poisoned]
@suo suo mentioned this pull request Jul 7, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77709116

This is the proposed `monarch.actor` submodule.

The public API is just a flat namespace, determined by `monarch/actor/__init__.py`.

*Everything else* is a private detail, signified by lots of underscores in filenames. That's a little unforunate, but I think draws some good boundaries, and keeps the API simple to the user.

Some principles that should guide us moving forward:
- **Every symbol has at most two locations**: a private location (which should be exactly the same as its location in the source tree), and optionally a public location in the user-facing API.
- We discourage end-users from depending on private locations via underscores, per python convention.

Differential Revision: [D77709116](https://our.internmc.facebook.com/intern/diff/D77709116/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77709116

This is the proposed `monarch.actor` submodule.

The public API is just a flat namespace, determined by `monarch/actor/__init__.py`.

*Everything else* is a private detail, signified by lots of underscores in filenames. That's a little unforunate, but I think draws some good boundaries, and keeps the API simple to the user.

Some principles that should guide us moving forward:
- **Every symbol has at most two locations**: a private location (which should be exactly the same as its location in the source tree), and optionally a public location in the user-facing API.
- We discourage end-users from depending on private locations via underscores, per python convention.

Differential Revision: [D77709116](https://our.internmc.facebook.com/intern/diff/D77709116/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77709116

This is the proposed `monarch.actor` submodule.

The public API is just a flat namespace, determined by `monarch/actor/__init__.py`.

*Everything else* is a private detail, signified by lots of underscores in filenames. That's a little unforunate, but I think draws some good boundaries, and keeps the API simple to the user.

Some principles that should guide us moving forward:
- **Every symbol has at most two locations**: a private location (which should be exactly the same as its location in the source tree), and optionally a public location in the user-facing API.
- We discourage end-users from depending on private locations via underscores, per python convention.

Differential Revision: [D77709116](https://our.internmc.facebook.com/intern/diff/D77709116/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77709116

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7465767.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants