-
Notifications
You must be signed in to change notification settings - Fork 48
[monarch] monarch.actor submodule #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is the proposed `monarch.actor` submodule. The public API is just a flat namespace, determined by `monarch/actor/__init__.py`. *Everything else* is a private detail, signified by lots of underscores in filenames. That's a little unforunate, but I think draws some good boundaries, and keeps the API simple to the user. Some principles that should guide us moving forward: - **Every symbol has at most two locations**: a private location (which should be exactly the same as its location in the source tree), and optionally a public location in the user-facing API. - We discourage end-users from depending on private locations via underscores, per python convention. Differential Revision: [D77709116](https://our.internmc.facebook.com/intern/diff/D77709116/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D77709116 |
This is the proposed `monarch.actor` submodule. The public API is just a flat namespace, determined by `monarch/actor/__init__.py`. *Everything else* is a private detail, signified by lots of underscores in filenames. That's a little unforunate, but I think draws some good boundaries, and keeps the API simple to the user. Some principles that should guide us moving forward: - **Every symbol has at most two locations**: a private location (which should be exactly the same as its location in the source tree), and optionally a public location in the user-facing API. - We discourage end-users from depending on private locations via underscores, per python convention. Differential Revision: [D77709116](https://our.internmc.facebook.com/intern/diff/D77709116/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D77709116 |
This is the proposed `monarch.actor` submodule. The public API is just a flat namespace, determined by `monarch/actor/__init__.py`. *Everything else* is a private detail, signified by lots of underscores in filenames. That's a little unforunate, but I think draws some good boundaries, and keeps the API simple to the user. Some principles that should guide us moving forward: - **Every symbol has at most two locations**: a private location (which should be exactly the same as its location in the source tree), and optionally a public location in the user-facing API. - We discourage end-users from depending on private locations via underscores, per python convention. Differential Revision: [D77709116](https://our.internmc.facebook.com/intern/diff/D77709116/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D77709116 |
This is the proposed `monarch.actor` submodule. The public API is just a flat namespace, determined by `monarch/actor/__init__.py`. *Everything else* is a private detail, signified by lots of underscores in filenames. That's a little unforunate, but I think draws some good boundaries, and keeps the API simple to the user. Some principles that should guide us moving forward: - **Every symbol has at most two locations**: a private location (which should be exactly the same as its location in the source tree), and optionally a public location in the user-facing API. - We discourage end-users from depending on private locations via underscores, per python convention. Differential Revision: [D77709116](https://our.internmc.facebook.com/intern/diff/D77709116/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D77709116 |
This is the proposed `monarch.actor` submodule. The public API is just a flat namespace, determined by `monarch/actor/__init__.py`. *Everything else* is a private detail, signified by lots of underscores in filenames. That's a little unforunate, but I think draws some good boundaries, and keeps the API simple to the user. Some principles that should guide us moving forward: - **Every symbol has at most two locations**: a private location (which should be exactly the same as its location in the source tree), and optionally a public location in the user-facing API. - We discourage end-users from depending on private locations via underscores, per python convention. Differential Revision: [D77709116](https://our.internmc.facebook.com/intern/diff/D77709116/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D77709116 |
This pull request has been merged in 7465767. |
Stack from ghstack (oldest at bottom):
This is the proposed
monarch.actor
submodule.The public API is just a flat namespace, determined by
monarch/actor/__init__.py
.Everything else is a private detail, signified by lots of underscores in filenames. That's a little unforunate, but I think draws some good boundaries, and keeps the API simple to the user.
Some principles that should guide us moving forward:
Differential Revision: D77709116