[monarch] initial commit of tensor_engine submodule #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the actor layer is place, time to refactor the tensor engine following the same principles: - Every symbol has at most two locations: a private location (which should be exactly the same as its location in the source tree), and optionally a public location in the user-facing API. - We discourage end-users from depending on private locations via underscores, per python convention. In particular, we violate principle 2 in many places in the tensor engine—all of our top-level files/modules are visible if you do `from monarch.foo import bar`, and we are sloppy about the distinction of public and private. So this refactor will be a little bit painful. I will approach it in parts. This diff defines the `tensor_engine` submodule and moves `common` to `monarch.tensor_engine._common`. Differential Revision: [D77847587](https://our.internmc.facebook.com/intern/diff/D77847587/) [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Jul 8, 2025
Now that the actor layer is place, time to refactor the tensor engine following the same principles: - Every symbol has at most two locations: a private location (which should be exactly the same as its location in the source tree), and optionally a public location in the user-facing API. - We discourage end-users from depending on private locations via underscores, per python convention. In particular, we violate principle 2 in many places in the tensor engine—all of our top-level files/modules are visible if you do `from monarch.foo import bar`, and we are sloppy about the distinction of public and private. So this refactor will be a little bit painful. I will approach it in parts. This diff defines the `tensor_engine` submodule and moves `common` to `monarch.tensor_engine._common`. Differential Revision: [D77847587](https://our.internmc.facebook.com/intern/diff/D77847587/) ghstack-source-id: 294791348 Pull Request resolved: #458
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77847587 |
Now that the actor layer is place, time to refactor the tensor engine following the same principles: - Every symbol has at most two locations: a private location (which should be exactly the same as its location in the source tree), and optionally a public location in the user-facing API. - We discourage end-users from depending on private locations via underscores, per python convention. In particular, we violate principle 2 in many places in the tensor engine—all of our top-level files/modules are visible if you do `from monarch.foo import bar`, and we are sloppy about the distinction of public and private. So this refactor will be a little bit painful. I will approach it in parts. This diff defines the `tensor_engine` submodule and moves `common` to `monarch.tensor_engine._common`. Differential Revision: [D77847587](https://our.internmc.facebook.com/intern/diff/D77847587/) [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Jul 8, 2025
Pull Request resolved: #458 Now that the actor layer is place, time to refactor the tensor engine following the same principles: - Every symbol has at most two locations: a private location (which should be exactly the same as its location in the source tree), and optionally a public location in the user-facing API. - We discourage end-users from depending on private locations via underscores, per python convention. In particular, we violate principle 2 in many places in the tensor engine—all of our top-level files/modules are visible if you do `from monarch.foo import bar`, and we are sloppy about the distinction of public and private. So this refactor will be a little bit painful. I will approach it in parts. This diff defines the `tensor_engine` submodule and moves `common` to `monarch.tensor_engine._common`. Differential Revision: [D77847587](https://our.internmc.facebook.com/intern/diff/D77847587/) ghstack-source-id: 294872880
|
This pull request was exported from Phabricator. Differential Revision: D77847587 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Now that the actor layer is place, time to refactor the tensor engine following the same principles:
In particular, we violate principle 2 in many places in the tensor engine—all of our top-level files/modules are visible if you do
from monarch.foo import bar, and we are sloppy about the distinction of public and private.So this refactor will be a little bit painful. I will approach it in parts. This diff defines the
tensor_enginesubmodule and movescommontomonarch.tensor_engine._common.Differential Revision: D77847587