Skip to content

perf: add __slots__ to SubtypeVisitor #19394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

perf: add __slots__ to SubtypeVisitor #19394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions mypy/subtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,15 @@ def check_type_parameter(


class SubtypeVisitor(TypeVisitor[bool]):
__slots__ = (
"right",
"orig_right",
"proper_subtype",
"subtype_context",
"options",
"_subtype_kind",
)

def __init__(self, right: Type, subtype_context: SubtypeContext, proper_subtype: bool) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a lot of SubtypeVisitor objects are created, it follows that a lot of SubtypeContext must also be created to pass into it, so I think adding __slots__ to SubtypeContext here should also yield some further improvement.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #19397

self.right = get_proper_type(right)
self.orig_right = right
Expand Down