perf: add __slots__ to SubtypeVisitor
#19394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ngnpope
reviewed
Jul 8, 2025
| "options", | ||
| "_subtype_kind", | ||
| ) | ||
|
|
||
| def __init__(self, right: Type, subtype_context: SubtypeContext, proper_subtype: bool) -> None: |
There was a problem hiding this comment.
If a lot of SubtypeVisitor objects are created, it follows that a lot of SubtypeContext must also be created to pass into it, so I think adding __slots__ to SubtypeContext here should also yield some further improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We construct quite a lot of them. This made a selfcheck benchmark 0.4-0.7% faster when run on my local PC.