Skip to content

gh-132070: use _PyObject_IsUniquelyReferenced in unicodeobject #132091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

gh-132070: use _PyObject_IsUniquelyReferenced in unicodeobject #132091

wants to merge 2 commits into from

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Apr 4, 2025 •
edited
Loading

Use _PyObject_IsUniquelyReferenced instead of Py_REFCNT(op)==1 as it is not thread safe in free-threading.

@bedevere-app bedevere-app bot mentioned this pull request Apr 4, 2025
Closed
@kumaraditya303 kumaraditya303 requested a review from colesbury April 4, 2025 15:38
@colesbury
Copy link
Contributor

Looks like the CI is failing

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@corona10 corona10 mentioned this pull request Apr 27, 2025
Merged
@corona10
Copy link
Member

I am now closing this PR Thanks for the investigation!
#133039

@corona10 corona10 closed this Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury Awaiting requested review from colesbury

Assignees
No one assigned
Labels
awaiting core review skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaraditya303 @colesbury @corona10