Skip to content

gh-132070: Use _PyObject_IsUniquelyReferenced in unicodeobject #133039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-132070: Use _PyObject_IsUniquelyReferenced in unicodeobject #133039

wants to merge 3 commits into from

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Apr 27, 2025 •
edited by bedevere-app bot
Loading

@corona10 corona10 changed the title Kumar test gh-132070: use _PyObject_IsUniquelyReferenced in unicodeobject Apr 27, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 27, 2025
Open
@corona10
Copy link
Member Author

corona10 commented Apr 27, 2025 •
edited
Loading

@kumaraditya303 @colesbury
I continued working on Kumar's PR #132091. In the new change, more states of unicode_modifiable are observed in free-threading builds. So I added a fallback to use resize_copy when unicode_modifiable fails, but I'm not sure if this is the right approach.
But the test failure issues are resolved.

@corona10 corona10 marked this pull request as ready for review April 27, 2025 10:12
@corona10 corona10 changed the title gh-132070: use _PyObject_IsUniquelyReferenced in unicodeobject gh-132070: Use _PyObject_IsUniquelyReferenced in unicodeobject Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury Awaiting requested review from colesbury

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303

Assignees
No one assigned
Labels
awaiting core review needs backport to 3.13 bugs and security fixes skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corona10 @kumaraditya303