Skip to content

[ci] Start testing on python 3.14-beta #2731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2025
Merged

[ci] Start testing on python 3.14-beta #2731

merged 3 commits into from
Jul 13, 2025

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
✨ New feature

@Pierre-Sassoulas Pierre-Sassoulas added this to the 4.0.0 milestone May 8, 2025
@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining astroid or the dev workflow python 3.14 labels May 8, 2025
@cdce8p
Copy link
Member

cdce8p commented May 15, 2025

I've been looking into the brain errors. Will open a PR to fix them later today.

@cdce8p cdce8p force-pushed the python3.14 branch 6 times, most recently from adaabd4 to 82e503f Compare May 16, 2025 15:53
@cdce8p
Copy link
Member

cdce8p commented May 16, 2025

Rebased the PR and fixed the remaining two test cases. Just wondering if we need to split the as_string case.
On my machine (macOS ARM) I'm also seeing outright Python crashes for two test cases. The CI run seems to be fine though.?

Both are already ignored for PyPy. When I run them locally, Python crashes with Abort trap: 6

  • tests/test_inference.py::InferenceTest::test_no_infinite_ancestor_loop
  • tests/test_inference.py::test_recursion_on_inference_tip

--
Also seeing a crash for one pylint test

  • tests/test_functional.py::test_functional[regression_5408]

@Pierre-Sassoulas
Copy link
Member Author

Just wondering if we need to split the as_string case.

I was trying to keep the return in finally for python < 3.14 but it's near impossible (very hard as we have 188 tests using it, we can't remove them all for python 3.14). Probably not something we're going to break by mistake, so probably safe to skip.

@Pierre-Sassoulas
Copy link
Member Author

My current guess with the last issue is either a fail of pytest under windows and python 3.14 or a cache issue on our side.

@Pierre-Sassoulas
Copy link
Member Author

Added backport label because we'll need 3.14 compat for pylint faster than we can properly release 4.0.0.

@jacobtylerwalls
Copy link
Member

Added backport label because we'll need 3.14 compat for pylint faster than we can properly release 4.0.0.

Maybe worth kicking this around in the discord #release-planning channel?

I could also envision us committing to spending our limited effort between now and October 1 on nothing but 3.14 compat (and optionally, possibly the simplest MVP of pylint-dev/pylint#3512) and releasing 4.0 by October 1. I think we should ship the new features people have contributed without waiting for too much else.

Copy link

codecov bot commented Jul 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.31%. Comparing base (e0a7642) to head (b19868d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2731      +/-   ##
==========================================
+ Coverage   93.29%   93.31%   +0.01%     
==========================================
  Files          92       92              
  Lines       11051    11051              
==========================================
+ Hits        10310    10312       +2     
+ Misses        741      739       -2     
Flag Coverage Δ
linux 93.18% <ø> (+0.01%) ⬆️
pypy 93.31% <ø> (+0.01%) ⬆️
windows 93.29% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pierre-Sassoulas Pierre-Sassoulas merged commit c94e0b7 into main Jul 13, 2025
22 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the python3.14 branch July 13, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow python 3.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants