Skip to content

[Backport maintenance/3.3.x] Initial fixes for Python 3.14 (#2747) #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2025

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented May 17, 2025

Backport 43111bb from #2747.

@cdce8p cdce8p added this to the 3.3.11 milestone May 17, 2025
@cdce8p cdce8p added Maintenance Discussion or action around maintaining astroid or the dev workflow python 3.14 labels May 17, 2025
Copy link

codecov bot commented May 17, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (maintenance/3.3.x@0aaf213). Learn more about missing BASE report.

Files with missing lines Patch % Lines
astroid/brain/brain_typing.py 80.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (88.88%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##             maintenance/3.3.x    #2748   +/-   ##
====================================================
  Coverage                     ?   93.06%           
====================================================
  Files                        ?       93           
  Lines                        ?    11082           
  Branches                     ?        0           
====================================================
  Hits                         ?    10313           
  Misses                       ?      769           
  Partials                     ?        0           
Flag Coverage Δ
linux 92.92% <88.88%> (?)
pypy 93.06% <88.88%> (?)
windows 93.04% <88.88%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
astroid/brain/brain_pathlib.py 91.66% <100.00%> (ø)
astroid/const.py 100.00% <100.00%> (ø)
astroid/brain/brain_typing.py 87.03% <80.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pierre-Sassoulas
Copy link
Member

Ha I tried to backport the whole MR but only this particular one was required ?

@cdce8p
Copy link
Member Author

cdce8p commented May 18, 2025

Ha I tried to backport the whole MR but only this particular one was required ?

We'll need both. I merged #2747 into main, not #2731.

@cdce8p cdce8p merged commit b1adb1c into pylint-dev:maintenance/3.3.x May 18, 2025
19 of 20 checks passed
@cdce8p cdce8p deleted the backport-2747 branch May 18, 2025 09:42
Pierre-Sassoulas added a commit that referenced this pull request Jul 13, 2025
* [fix] Crash when parsing an empty arbitrary expression with ``extract_node`` (#2736) (#2737)

Closes #2734

(cherry picked from commit 59f36e7)

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>

* [fix] Prevent crash on slice decorator for 'six' decorated function (#2738) (#2740)

Closes #2721

(cherry picked from commit 555a128)

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>

* [Backport maintenance/3.3.x] Initial fixes for Python 3.14 (#2747) (#2748)

(cherry picked from commit 43111bb)

* Improve backport job permissions (#2750)

(cherry picked from commit fe5bb6c)

* Use custom Github App to authenticate backport job (#2751) (#2752)

(cherry picked from commit a6f8d6a)

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>

* Include subclasses of standard property classes as property decorators (#2735)

* Include subclasses of standard property types as property decorators

* Modify astroid.bases and tests.test_nodes to reflect that enum.property was added in Python 3.11, not 3.10

* Apply suggestions from code review

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>

---------

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
(cherry picked from commit 30128b7)

* Bump astroid to 3.3.11, update changelog (#2777)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Co-authored-by: pylint-backport-bot[bot] <212256041+pylint-backport-bot[bot]@users.noreply.github.com>
Co-authored-by: Mitch Harding <mitchell.harding@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow python 3.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants