Skip to content

update kitchen sink pages #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025
Merged

update kitchen sink pages #2190

merged 2 commits into from
May 1, 2025

Conversation

drammock
Copy link
Collaborator

closes #2038

@drammock
Copy link
Collaborator Author

@gabalafou
Copy link
Collaborator

gabalafou commented Apr 28, 2025

Unfortunately, the accessibility test failures are real. The update to the kitchen sink brought in some new links. These new links do not meet color contrast thresholds (WCAG AA). Some screen shots below:

Light mode

In light mode, the link color is #0a7d91.

link in topic admonition (gray background) link in version added admonition (light green background)

(same goes for versionchanged, deprecated, and versionremoved admonitions)

the links added to the list table do not have enough contrast against the gray background

Dark mode

In dark mode, the link color is #3fb1c5 and it has enough contrast with all of the admonition backgrounds except one.

link in version changed admonition in dark mode (dark orange background)

Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I am going to approve and merge this PR.
The colour contrast issues can be fixed separately (I already opened an issue).

@trallard trallard merged commit 400fdc1 into pydata:main May 1, 2025
20 of 31 checks passed
@drammock
Copy link
Collaborator Author

drammock commented May 1, 2025

hooray for the kitchen sink actually revealing some legitimate issues! I'm always grumpy about all the spurious API docstring warnings that it causes, it's nice for it to "earn its keep" for a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC - Broken image links in "Kitchen Sink->Images & Figures"
3 participants