MAINT - Fix linkcheck failures #2207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 12, 2025 14:54
trallard
added
kind: bug
stevepiercy
reviewed
May 12, 2025
gabalafou
reviewed
May 12, 2025
gabalafou
reviewed
May 12, 2025
There was a problem hiding this comment.
Almost there! I think the gnu.org gettext regex needs updating, and @stevepiercy's comment needs to be addressed
| @@ -389,7 +390,7 @@ def setup(app: Sphinx) -> Dict[str, Any]: | |||
| r"https://virtualenv.pypa.io/": "https://virtualenv.pypa.io/en/latest/", | |||
| # catching redirects in rtd | |||
| r"https://[A-Za-z\d_\-\.]+.readthedocs.io/": r"https://[A-Za-z\d_\-\.]+\.readthedocs\.io(/en)?/(stable|latest)/", | |||
| r"https://readthedocs.org/": r"https://about.readthedocs.com\?ref=readthedocs.org", | |||
| r"https://readthedocs.org/": r"https://about.readthedocs.com/\?ref=app.readthedocs.org", | |||
There was a problem hiding this comment.
Should we change the link to readthedocs.org to https://about.readthedocs.com?
There was a problem hiding this comment.
I believe the canonical URL is/should be readthedocs.com, I do not think we need to change it.
gabalafou
requested changes
May 12, 2025
stevepiercy
reviewed
May 13, 2025
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
7 tasks
gabalafou
approved these changes
May 14, 2025
|
This looks good to me! Looking forward to having the CI all green again. 😌 I can't merge this because of the failing lighthouse check (expected until you rebase main), so I'll let you do the honors. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few broken links/redirects in the docs that are currently causing the CI to fail. This PR should fix these.