Skip to content

Update docs for KolSelect best practice #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

Update docs for KolSelect best practice #337

merged 1 commit into from
Jun 20, 2025

Conversation

laske185
Copy link
Contributor

@laske185 laske185 commented Jun 19, 2025 •
edited
Loading

Summary

  • clarify best practice for Select component options

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2025 •
edited
Loading

Netlify Draft Deployment
URL: https://6853db2e33cfb95449334114--docs-kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/projects/docs-kolibri-public-ui/deploys/6853db2e33cfb95449334114

@laske185 laske185 force-pushed the feature/dokumentation-zu-select-elementen-aktualisieren branch from 9e61351 to c4e8401 Compare June 19, 2025 09:37
@laske185 laske185 linked an issue Jun 19, 2025 that may be closed by this pull request
Disabled Options sind problematisch mit NVDA - KNOWN ISSUES #336
Closed
@laske185 laske185 requested a review from deleonio June 19, 2025 09:38
@laske185 laske185 marked this pull request as ready for review June 19, 2025 09:39
@deleonio deleonio merged commit 2f3015b into main Jun 20, 2025
4 of 5 checks passed
@deleonio deleonio deleted the feature/dokumentation-zu-select-elementen-aktualisieren branch June 20, 2025 07:00
@publicuibot publicuibot bot locked and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deleonio deleonio deleonio approved these changes

Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabled Options sind problematisch mit NVDA - KNOWN ISSUES
2 participants
@laske185 @deleonio